Use specific failure categories before agent_failure in failure-issue routing#44498
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add classification of failure causes before reporting issues
Use specific failure categories before Jul 9, 2026
agent_failure in failure-issue routing
pelikhan
marked this pull request as ready for review
July 9, 2026 10:55
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request tightens failure-category classification in the report-failure-as-issue routing logic so that agent_failure is emitted only as a true fallback when no more specific failure category was detected, reducing noise in category-based include/exclude filters.
Changes:
- Updated
buildFailureMatchCategories(...)to addagent_failureonly when the job failed, did not time out, and no specific failure category has been detected. - Added/updated tests to assert
agent_failureis omitted when a specific category (e.g.,report_incomplete,awf_firewall_startup_failed) exists. - Extended filter-behavior tests to ensure infra-classified failures (e.g.,
inference_access_error) do not match include-only["agent_failure"]filters.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/handle_agent_failure.cjs | Makes agent_failure a fallback-only category when no other specific failure category has been detected. |
| actions/setup/js/handle_agent_failure.test.cjs | Adds assertions covering fallback-only behavior and category-filter routing with infra-classified failures. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
Contributor
|
❌ Test Quality Sentinel failed during test quality analysis. |
Contributor
|
|
Contributor
|
❌ Design Decision Gate 🏗️ failed during design decision gate check. |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
report-failure-as-issuewas treating many non-agent failures asagent_failurebecause generic classification was always added on job failure. That made category filters noisy, especially for infra/transient failure modes where existing specific categories already exist.Failure classification tightening
buildFailureMatchCategories(...)inhandle_agent_failure.cjsto emitagent_failureonly as a fallback.agent_failureis now added only when:Category-filter behavior alignment
inference_access_error,report_incomplete,awf_firewall_startup_failed) as the primary signal used byreport-failure-as-issueinclude/exclude filters.["agent_failure"]no longer match infra-classified failures just because the job failed.Targeted test updates
agent_failureis omitted when specific categories are present.["agent_failure"]filters.